Walshy/mc 1.21 bundles #4299
Open
Walshy/mc 1.21 bundles #4299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istener to use the wrapper on Player#getOpenInventory
Co-authored-by: Daniel Walsh <[email protected]>
# Conflicts: # pom.xml # src/main/java/io/github/thebusybiscuit/slimefun4/api/gps/GPSNetwork.java # src/main/java/io/github/thebusybiscuit/slimefun4/api/items/SlimefunItemStack.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/cargo/ReactorAccessPort.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/machines/CarbonPress.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/machines/ElectricPress.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/machines/HeatedPressureChamber.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/electric/reactors/Reactor.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/magical/talismans/EnderTalisman.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/magical/talismans/Talisman.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/setup/DefaultItemGroups.java # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/setup/SlimefunItemSetup.java # src/test/java/io/github/thebusybiscuit/slimefun4/implementation/items/TestSlimefunItem.java
|
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
Intybyte
force-pushed
the
walshy/mc-1.21-bundles
branch
from
a178eee to
42655d1
Compare
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4299/08a51899
|
ybw0014
suggested changes
Apr 12, 2025
src/main/java/io/github/thebusybiscuit/slimefun4/utils/tags/SlimefunTag.java
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/BundlingListener.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened version of #4278
Description
Bundles in 1.21.3+ will create some problems with backpacks that need to be addressed
Issues
Proposed changes
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values